Skip to content

Remove MTE-5303 Remove test that's no longer in TestRail#33910

Open
clarmso wants to merge 3 commits into
mainfrom
cs/MTE-5303-remove-deleted-test
Open

Remove MTE-5303 Remove test that's no longer in TestRail#33910
clarmso wants to merge 3 commits into
mainfrom
cs/MTE-5303-remove-deleted-test

Conversation

@clarmso
Copy link
Copy Markdown
Collaborator

@clarmso clarmso commented May 20, 2026

📜 Tickets

💡 Description

testAddToReadingListFromBrowserTabMenu is an old test that's no longer in TestRail. I have also fixed a typo and also a link from full functional test plan.

TODO: The following tests do not have a valid TestRail link, but I am unsatified with the answer from Claude Code. Still looking for a resolution.

  Current ID: 2306920
  File: JumpBackInTests.swift:49               
  Test: testPrivateTab                         
  Suggested ID: 2307004 "Private tab does not track history"
  Match Reason: testPrivateTab found in automated test names      
  ────────────────────────────────────────     
  Current ID: 2307034                          
  File: HomePageSettingsUITest.swift:225
  Test: testRecentlySaved                      
  Suggested ID: 2306919 "Validate that The latest 8 saved bookmarks are always displayed"
  Match Reason: testRecentlySaved found in automated test names    
  ────────────────────────────────────────    
  Current ID: 2575177
  File: LegacyOnboardingTests.swift:257
  Test: testLegacyOnboardingCloseOptionLastCard
  Suggested ID: 2575170 "Choose to close option"
  Match Reason: No automated test name match; best title match — test navigates to the last card and closes via X button

🎥 Demos

Before After
Demo

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@clarmso clarmso requested review from isabelrios and mdotb-moz May 20, 2026 04:16
@clarmso clarmso requested a review from a team as a code owner May 20, 2026 04:16
@mobiletest-ci-bot
Copy link
Copy Markdown

mobiletest-ci-bot commented May 20, 2026

💪 Quality guardian

2 tests files modified. You're a champion of test coverage! 🚀

🧹 Tidy commit

Just 2 file(s) touched. Thanks for keeping it clean and review-friendly!

✅ New file code coverage

No new file detected so code coverage gate wasn't ran.

✅ Existing file code coverage

No modified file detected so code coverage gate wasn't ran.

Generated by 🚫 Danger Swift against 0f8f321

Copy link
Copy Markdown
Contributor

@mdotb-moz mdotb-moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}

// https://mozilla.testrail.io/index.php?/cases/view/2287278f
// https://mozilla.testrail.io/index.php?/cases/view/2306994
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix typo. I confirmed that the link points to testLoadReaderContent() test

import Foundation

class PrintTests: BaseTestCase {
// https://mozilla.testrail.io/index.php?/cases/view/3082504
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link points to the case in QA-4150, not from Full Functional Test Plan. The revised URL points to the test from Full Functional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants